Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #39933

Merged
merged 11 commits into from
Feb 18, 2017
Merged

Rollup of 5 pull requests #39933

merged 11 commits into from
Feb 18, 2017

Conversation

CBenoit and others added 11 commits February 15, 2017 13:44
1. Clarify that `String::split_off` returns one string and modifies self
   in-place. The documentation implied that it returns two new strings.

2. Make the documentation mirror `Vec::split_off`.
Correct a typo in procedural macros chapter of the Book.

A simple and short correction for procedural macros chapter of the Rust Programming Language Book.
…illaumeGomez

Fix wording in LocalKey documentation

Fixes rust-lang#39841

r? @GuillaumeGomez
… r=frewsxcv

Fixup String::split_off documentation

1. Clarify that `String::split_off` returns one string and modifies self in-place. The documentation implied that it returns two new strings.

2. Make the documentation mirror `Vec::split_off`.
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez
Copy link
Member Author

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented Feb 18, 2017

📌 Commit 98c2cf2 has been approved by GuillaumeGomez

@bors
Copy link
Contributor

bors commented Feb 18, 2017

⌛ Testing commit 98c2cf2 with merge 306035c...

bors added a commit that referenced this pull request Feb 18, 2017
Rollup of 5 pull requests

- Successful merges: #39847, #39862, #39898, #39904, #39928
- Failed merges:
@bors
Copy link
Contributor

bors commented Feb 18, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: GuillaumeGomez
Pushing 306035c to master...

@bors bors merged commit 98c2cf2 into rust-lang:master Feb 18, 2017
@GuillaumeGomez GuillaumeGomez deleted the rollup branch February 18, 2017 21:31
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants